chore(comms): bump WsLogAccess wsdl to 1.08#4376
Merged
GordonSmith merged 1 commit intoMay 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the WsLogAccess wsdl to version 1.08. It updates import paths to use the new v1.08 implementation and adjusts the service utilities accordingly.
- Updated service version string derivation in the utils module.
- Added a new ws_logaccess implementation under v1.08.
- Updated the import reference in the wsLogaccess service file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/comms/utils/index.ts | Updated serviceVersion by removing the nullish fallback. |
| packages/comms/src/services/wsdl/ws_logaccess/v1.08/ws_logaccess.ts | New ws_logaccess implementation with version bump but constructor still hardcodes "1.07". |
| packages/comms/src/services/wsLogaccess.ts | Updated import path from v1.05 to v1.08. |
GordonSmith
approved these changes
May 28, 2025
Member
|
@jeclrsg the copilot comments seem reasonable - is the version issue a generator issue? |
Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
jeclrsg
force-pushed
the
bump-ws-logaccess-1.08
branch
from
317ca0b to
1296b80
Compare
Contributor
Author
It isn't. Rodrigo changed his feature branch to include a new version number for the service. So I must admit I didn't pull the branch, recompile and rerun the wsdl parser, I just edited my PR by hand and missed that second instance of the version number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: